Skip to content

232 & 317: Create contribution guidelines, remove .vscode directory#322

Merged
kinskiwu merged 2 commits into
devfrom
232-create-contribution-guidelines
Jul 13, 2024
Merged

232 & 317: Create contribution guidelines, remove .vscode directory#322
kinskiwu merged 2 commits into
devfrom
232-create-contribution-guidelines

Conversation

@ejwoods
Copy link
Copy Markdown
Contributor

@ejwoods ejwoods commented Jul 12, 2024

Description

Create contribution guidelines

  • created .github/docs/CONTRIBUTING.md
    • this file establishes guidelines for contributing to the Linkta repository. The primary use of this file currently is to describe necessary vscode workspace settings. In the future, it can be expanded to describe the process of making Open Source contributions to the project.

Remove .vscode directory

  • removed .vscode/settings.json
    • this directory is already in the gitignore so I'm not certain how it ended up in the repo. I expect that when this PR is merged, any open PRs from branches tracking the directory will have a conflict; so as long as they also remove it, we should be able to prevent it from getting back in.

Fixes #232, #317

Type of change

  • 📝 Documentation update

How Can this be tested? Testing Plan to review this PR

  • Where in the app does this change take place?
    • the root and .github/docs/ directories
  • What are the steps to test this change?
    • read over .github/docs/CONTRIBUTING.md and ensure descriptions are accurate
    • check that the .vscode/ directory has been removed from the root level of the project. Creating a new one should not be tracked by git.

Checklist:

  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have reviewed the Security Best Practices Document.
  • I have followed the Naming Conventions Guide for my changes.
  • I have ensured that my pull request title is descriptive.

Additional Information:

@ejwoods ejwoods added the documentation Improvements or additions to documentation label Jul 12, 2024
@ejwoods ejwoods self-assigned this Jul 12, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2024

Deploy Preview for linkta-core ready!

Name Link
🔨 Latest commit 342154a
🔍 Latest deploy log https://app.netlify.com/sites/linkta-core/deploys/6691b5e952d95c00083cffaa
😎 Deploy Preview https://deploy-preview-322--linkta-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@kinskiwu kinskiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Ty!

@kinskiwu kinskiwu added this pull request to the merge queue Jul 13, 2024
Merged via the queue into dev with commit 3082b60 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Create contribution guidelines

3 participants