Skip to content

Conversation

@albinekb
Copy link
Contributor

@albinekb albinekb commented Dec 5, 2017

Fix #4

Two potential improvements:

  • Key::Char('k') will only match lowercase k, so if you have caps lock on you can't navigate, feature or bug? 🤔
  • Should i make up/down selected a function and share it between all the keys that do the same thing or is this good enough?

Both are fixed 👍

@LinusU
Copy link
Owner

LinusU commented Dec 6, 2017

Awesome 👏

How about adding two lines more, with Key::Char('K') and Key::Char('L')?

@LinusU
Copy link
Owner

LinusU commented Dec 6, 2017

Perfect!

@LinusU LinusU merged commit 20dfd43 into LinusU:master Dec 6, 2017
@albinekb albinekb deleted the bind-kj-picker branch December 6, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

K and J for moving up and down

2 participants