Skip to content

as breaking changes in http dart packet please fix example in a readme#148

Merged
LinusU merged 2 commits intoLinusU:masterfrom
Doldrums:patch-1
Dec 15, 2022
Merged

as breaking changes in http dart packet please fix example in a readme#148
LinusU merged 2 commits intoLinusU:masterfrom
Doldrums:patch-1

Conversation

@Doldrums
Copy link
Copy Markdown
Contributor

thank you folks

as breaking changes in http dart packet please consider to use
@Doldrums
Copy link
Copy Markdown
Contributor Author

@timshadel please my friend take a look

@LinusU
Copy link
Copy Markdown
Owner

LinusU commented Dec 15, 2022

The url parameter is currently a String, and not an Uri, so I'm not sure that this change is correct?

static Future<String> authenticate({required String url, required String callbackUrlScheme, bool? preferEphemeral}) async {

What breaking change is it that happened in the http dart package?

@Doldrums
Copy link
Copy Markdown
Contributor Author

check diff more carefully
https://pub.dev/documentation/http/latest/http/post.html

@LinusU
Copy link
Copy Markdown
Owner

LinusU commented Dec 15, 2022

Ah, I missed that it wasn't a call to this library that was changed 😅

LGTM 👍

Comment thread README.md Outdated
@LinusU LinusU merged commit 6afdfdc into LinusU:master Dec 15, 2022
@LinusU
Copy link
Copy Markdown
Owner

LinusU commented Dec 15, 2022

Thank you for the PR! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants