Conversation
- removed fhir-replication-api - removed extraneous comments Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112
commented
Oct 22, 2019
lmsurpre
reviewed
Oct 23, 2019
lmsurpre
reviewed
Oct 23, 2019
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Member
|
This looks good to me, but we'll need to consider how to deploy this on our cloud instance. Since we havn't had an R4 release yet, this one assumes a fresh database. To perform the migration, I think we'd need to delete the two fhir_replication_* tables and update the stored procedure to reduce the number of input variables. In the longer term, we have #270 for investigating and documenting our schema change procedure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #134