Skip to content

Issue #329 - Invalid SQL generated in ResourceDAOImpl #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnTimm merged 3 commits into from
Oct 29, 2019
Merged

Issue #329 - Invalid SQL generated in ResourceDAOImpl #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9658da2
Issue #329 - Invalid SQL generated in ResourceDAOImpl
JohnTimm Oct 29, 2019
7fb714d
Issue #329 - paging context validation
JohnTimm Oct 29, 2019
301c86a
Issue #329 - remove Math.intExact casts on total count
JohnTimm Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fhir-core/src/main/java/com/ibm/fhir/core/context/FHIRPagingContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ public interface FHIRPagingContext {
int getLastPageNumber();
int getPageNumber();
int getPageSize();
long getTotalCount();
int getTotalCount();
void setLastPageNumber(int lastPageNumber);
void setPageNumber(int pageNumber);
void setPageSize(int pageSize);
void setTotalCount(long totalCount);
void setTotalCount(int totalCount);
boolean isLenient();
void setLenient(boolean lenient);
}
17 changes: 14 additions & 3 deletions fhir-core/src/main/java/com/ibm/fhir/core/context/impl/FHIRPagingContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ public class FHIRPagingContextImpl implements FHIRPagingContext {
protected int lastPageNumber;
protected int pageNumber;
protected int pageSize;
protected long totalCount;
protected int totalCount;
protected boolean lenient = true;

public FHIRPagingContextImpl() {
this.pageNumber = DEFAULT_PAGE_NUMBER;
Expand All @@ -40,7 +41,7 @@ public int getPageSize() {
}

@Override
public long getTotalCount() {
public int getTotalCount() {
return totalCount;
}

Expand All @@ -60,7 +61,17 @@ public void setPageSize(int pageSize) {
}

@Override
public void setTotalCount(long totalCount) {
public void setTotalCount(int totalCount) {
this.totalCount = totalCount;
}

@Override
public boolean isLenient() {
return lenient;
}

@Override
public void setLenient(boolean lenient) {
this.lenient = lenient;
}
}
Loading