Skip to content

Issue #329 - skip resource query if pageSize == 0#333

Merged
JohnTimm merged 7 commits intomasterfrom
johntimm-master
Oct 30, 2019
Merged

Issue #329 - skip resource query if pageSize == 0#333
JohnTimm merged 7 commits intomasterfrom
johntimm-master

Conversation

@JohnTimm
Copy link
Copy Markdown
Collaborator

@JohnTimm JohnTimm commented Oct 30, 2019

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

@JohnTimm
Issue #329 - set summary parameter if pageSize == 0
5e65b31 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm assigned prb112 and albertwang-ibm and unassigned prb112 Oct 30, 2019
@JohnTimm JohnTimm requested a review from lmsurpre October 30, 2019 02:19
albertwang-ibm
albertwang-ibm approved these changes Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@albertwang-ibm albertwang-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnTimm
Issue #329 - Javadoc tweak
6289c6f 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #329 - reverted change added pageSize > 0 condition
cd15f7d 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm changed the title Issue #329 - set summary parameter if pageSize == 0 Issue #329 - skip resource query if pageSize == 0 Oct 30, 2019
@JohnTimm
Issue #329 - added unit test for pageSize == 0
476ea6f 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #329 - skip links if pageSize == 0
40ac10a 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #329 - clean up logic in FHIRResource.addLinks
aad7d50 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #329 - futher refinment of FHIRResource.addLinks
88e9c87 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm merged commit 178681f into master Oct 30, 2019
@JohnTimm JohnTimm deleted the johntimm-master branch October 30, 2019 03:09
@JohnTimm JohnTimm restored the johntimm-master branch October 30, 2019 03:09
albertwang-ibm
albertwang-ibm reviewed Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@albertwang-ibm albertwang-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmsurpre lmsurpre Awaiting requested review from lmsurpre

1 more reviewer

@albertwang-ibm albertwang-ibm albertwang-ibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@albertwang-ibm albertwang-ibm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnTimm @lmsurpre @albertwang-ibm @prb112