Conversation
this commit introduces a dependency on https://github.com/marketplace/actions/setup-java-environment-based-on-adoptopenjdk Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
approved these changes
Oct 30, 2019
Contributor
prb112
left a comment
prb112
left a comment
There was a problem hiding this comment.
LGTM...
one suggestion on -ntp to cut down on the transfer progress logs
prb112
reviewed
Oct 30, 2019
prb112
reviewed
Oct 30, 2019
prb112
reviewed
Oct 30, 2019
prb112
reviewed
Oct 30, 2019
prb112
reviewed
Oct 30, 2019
as suggested by Paul during review however, since we're already running maven in batch mode, adding this flag just skips the following lines: ``` [INFO] Downloading from central: ... [INFO] Downloaded from central: ... (8.1 kB at 24 kB/s) ``` Download errors should still show up. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com> Co-Authored-By: Paul Bastide <pbastide@us.ibm.com>
it still builds with OpenJDK 11, it just cross-compiles for java 1.8. i kept the java.version property, so folks can still pass `-Djava.version=11` if they really want to compile for java 11, but since we want to be buildable and runnable on java 8 we won't be using any java 11 source features at this time. also set fail-fast to false so that we get both java 8 and java 11 results each time Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
github-action
branch
from
2572035 to
adc31e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit introduces a dependency on https://github.com/marketplace/actions/setup-java-environment-based-on-adoptopenjdk
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com