Conversation
1. Updated the SearchPerformanceTest so that the observations have components with values...just to easily create many observations which helps verify the search behavior. This change could be removed if we want. 2. Deleted unused variants of searchForIds and searchByIds. I think these came from the original "basic" schema that was removed for #93 but they were no longer in use and should be safe to delete. 3. Introduced ORDER BY CASE clause to ResourceDAOImpl.searchByIds. I found that DERBY is always returning the results in the same order as the resource ids provided in the "IN" clause, but in general we shouldn't rely on that. I tested the CASE statements on derby with up to 1000 results, but we need to run a similar test on Db2 to ensure it works there as well. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
albertwang-ibm
approved these changes
Nov 15, 2019
Contributor
albertwang-ibm
left a comment
albertwang-ibm
left a comment
There was a problem hiding this comment.
LGTM, simple and easy, I like this!
Contributor
|
still a lit bit surprised to see that we search and find the ids first and then search those ids to get the results, just curious, why don't we get the full results in the first search. |
Member
Author
|
@JohnTimm can you address Albert's comment? Pretty sure it was like this before I got in here, but not sure on the reasoning. Does it help to leave out the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the SearchPerformanceTest so that the observations have
components with values...just to easily create many observations which
helps verify the search behavior. This change could be removed if we
want.
Deleted unused variants of searchForIds and searchByIds. I think
these came from the original "basic" schema that was removed for
Remove all references to the "basic" schema #93 but they were no longer in use and
should be safe to delete.
Introduced ORDER BY CASE clause to ResourceDAOImpl.searchByIds.
I found that DERBY is always returning the results in the same order as
the resource ids provided in the "IN" clause, but in general we
shouldn't rely on that. I tested the CASE statements on derby with up
to 1000 results, but we need to run a similar test on Db2 to ensure it
works there as well.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com