Skip to content

Issue #389 - fixed issues related to failing FHIRPathSpec tests#421

Merged
prb112 merged 1 commit intomasterfrom
johntimm-master
Nov 15, 2019
Merged

Issue #389 - fixed issues related to failing FHIRPathSpec tests#421
prb112 merged 1 commit intomasterfrom
johntimm-master

Conversation

@JohnTimm
Copy link
Copy Markdown
Collaborator

  • Updated visitNumberLiteral to use presence of a decimal point instead of exceptions to control logic flow
  • Updated FHIRPathNumberValue.isComparableTo/compareTo to accommodate newly introduced FHIRPathQuantityNode
  • Updated FHIRPathDateTimeValue and FHIRPathTimeValue classes with new patterns per the updated FHIRPath grammar

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from prb112 November 15, 2019 21:33
Copy link
Copy Markdown
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 merged commit fc39c3d into master Nov 15, 2019
@prb112 prb112 deleted the johntimm-master branch November 15, 2019 21:49
@JohnTimm JohnTimm restored the johntimm-master branch November 20, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants