issue #518 - remove audit db from default config#521
Merged
prb112 merged 1 commit intolee-masterfrom Dec 19, 2019
Merged
Conversation
Its simply not used any more, so its silly to keep creating it. I also removed the `resourceName` concept from both the Audit Context object and also the FHIRConfiguration config props. In the future, I'd also like to remove the undocumented `fhirServer/audit/patientIdExtensionUrl` config property, but that one wasn't quite as clean to remove right now...we need to think through whether/how to include the data subject (e.g. Patient) identifier in the audit log in a more FHIR-native way. Finally, I included some unrelated minor updates to the `fhir-persistence-schema` README.md; now the examples all use the `default` tenant...this is the simplest option because otherwise everyone needs to understand our tenancy model just to get something working on Db2. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its simply not used any more, so its silly to keep creating it.
I also removed the
resourceNameconcept from both the Audit Contextobject and also the FHIRConfiguration config props.
In the future, I'd also like to remove the undocumented
fhirServer/audit/patientIdExtensionUrlconfig property, but that onewasn't quite as clean to remove right now...we need to think through
whether/how to include the data subject (e.g. Patient) identifier in the
audit log in a more FHIR-native way.
Finally, I included some unrelated minor updates to the
fhir-persistence-schemaREADME.md; now the examples all use thedefaulttenant...this is the simplest option because otherwiseeveryone needs to understand our tenancy model just to get something
working on Db2.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com