Fix: (#700) Improve error reporting for Query in fileLoader and nonLoader. #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Query methods in fileLoader and nonLoader previously either returned a "not support" message via the data payload (fileLoader) or failed silently (nonLoader), both with a nil error. This commit changes them to return explicit non-nil errors, indicating that the Query functionality is not implemented for these loader types. This aligns better with Go's error handling conventions and provides clearer feedback to callers.
|
LinuxSuRen
reviewed
May 29, 2025
There was a problem hiding this comment.
Hi @KariHall619 ， thanks for your effort. But please upload some screenshots about the test process. I guess you already tested it on the web UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #700
What type of PR is this?
Fix: Improve error reporting for unimplemented Query in loaders
What this PR does / why we need it:
This PR refactors the Query methods in pkg/testing/loader_file.go and pkg/testing/loader_non.go.
Previously, these methods did not clearly indicate their inability to perform database queries in a way that aligns with Go's error handling conventions:
fileLoader.Query returned a nil error while passing a "not support" message through the data payload.
nonLoader.Query returned a nil error and an empty result, failing silently.
These behaviors made it harder for calling code to reliably determine if a query was unsupported and could lead to confusion during debugging.
This change modifies both methods to return an explicit, non-nil error (e.g., errors.New("Query functionality is not yet implemented for fileLoader")). This provides: