Skip to content

Fix: (#700) Improve error reporting for Query in fileLoader and nonLoader. #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Fix: (#700) Improve error reporting for Query in fileLoader and nonLoader. #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/testing/loader_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package testing
import (
"bytes"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
Expand Down Expand Up @@ -516,8 +517,11 @@ func (l *fileLoader) Close() {
}

func (l *fileLoader) Query(query map[string]string) (result DataResult, err error) {
result.Pairs = map[string]string{
"message": "not support",
}
err = errors.New("Query functionality is not yet implemented for fileLoader")
return
}

func (l *fileLoader) GetRoundTripper(name string) (roundTripper http.RoundTripper, err error) {
err = fmt.Errorf("not support")
return
}
5 changes: 5 additions & 0 deletions pkg/testing/loader_non.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ limitations under the License.
*/
package testing

import (
"errors"
)

// nonLoader is an empty implement for avoid too many nil check
type nonLoader struct{}

Expand Down Expand Up @@ -151,5 +155,6 @@ func (l *nonLoader) Close() {
}

func (l *nonLoader) Query(query map[string]string) (result DataResult, err error) {
err = errors.New("Query functionality is not implemented for nonLoader")
return
}
Loading