ntp-ntpd: Fixed unpacking of ntpq -p values#758
Merged
markuslf merged 1 commit intoLinuxfabrik:mainfrom May 3, 2024
Merged
Conversation
When the chosen ntp Server (maked by *) has one or more whitespaces in its name, the original parsing fails with too many values to unpack. Example: '*185.232.69.65 ( 79.133.44.146 2 u 139 256 377 0.401 0.133 0.137' peer, refid, stratum, _type, when, poll, reach, delay, offset, jitter = line[1:].split() ValueError: too many values to unpack (expected 10)
Member
|
Thank you. I also enhanced the unit tests. |
markuslf
added a commit
that referenced
this pull request
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the chosen ntp Server (maked by *) has one or more whitespaces in its name, the original parsing fails with too many values to unpack.
Example:
peer, refid, stratum, _type, when, poll, reach, delay, offset, jitter = line[1:].split()
ValueError: too many values to unpack (expected 10)
A fix is to directly access the variables after remote via a negative index, as every value after is properly sanitized.
I also removed all unused extracted variables.