Skip to content

[codex] Add ELF-driven model fixtures and trace checks#1

Merged
zhoubot merged 3 commits intomainfrom
codex/model-llvm-elf-fixtures
Apr 9, 2026
Merged

[codex] Add ELF-driven model fixtures and trace checks#1
zhoubot merged 3 commits intomainfrom
codex/model-llvm-elf-fixtures

Conversation

@zhoubot
Copy link
Copy Markdown
Contributor

@zhoubot zhoubot commented Apr 9, 2026

What changed

  • add the ELF/program-image loader, Minst decode/disassembly stack, and the reference/compare CLI path in tools/model
  • add richer Minst trace decoration and objdump-style .dump output next to JSONL traces
  • add committed LLVM-built ELF fixtures plus a manifest/regeneration script, and a ctest check that runs linx_model_cli against those ELF inputs

Why

  • the model tests previously relied on handcrafted binaries instead of real LLVM-produced ELF inputs
  • we need deterministic, repo-owned fixture coverage that exercises the ELF loader, disassembler, and reference executor on the same examples every run
  • this also closes the loop for the current AVS model smoke sources and keeps the trace/schema path under test

Impact

  • ctest now includes linx_model_check_llvm_elf_fixtures
  • fixture regeneration is documented and scriptable from a superproject checkout
  • Minst trace output carries canonical JSON fields plus objdump-style dump lines for review/debugging

Validation

  • ctest --test-dir /Users/zhoubot/linx-isa/tools/model/build --output-on-failure
  • python3 /Users/zhoubot/linx-isa/tools/model/tests/fixtures/llvm_elf/regenerate_llvm_elf_fixtures.py --root /Users/zhoubot/linx-isa/tools/model

@gemini-code-assist
Copy link
Copy Markdown

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

@zhoubot zhoubot marked this pull request as ready for review April 9, 2026 12:05
@zhoubot zhoubot merged commit ed0bc04 into main Apr 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant