Added Match-V5 support to getMatchList(accountObject) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to MATCH-V5 format, added getpuuidFromParam(), getRegionForMatchv5()
Open
Owner
|
Thanks! I've been sleeping on this project, appreciate the Pull Request |
Contributor
Author
Glad I could help! Been playing around with Match-V5 so I thought I'd help out. Will look into updating the other match methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have been made to getMatchList() since Match-V4 is deprecated.
Commented out Match-V4 GET urls
GET_MATCHLIST_URL updated with Match-V5 GET URL
getMatchList now requires puuid, changes made acoordingly
getpuuidFromParam() function added to retrieve puuid from LeagueAccountInfo
getRegionForMatchv5() function added to use proper regions for Match-V5 GET calls (Americas, Asia, Europe) - works only for NA1 at the moment