refactor(tool): rename search_issues to search across all surfaces (patch)#127
Merged
liplus-lin-lay merged 1 commit intoApr 25, 2026
Conversation
Tool name was misleading — the unified tool searches issues, PRs, releases, docs, commit diffs, comments, reviews, and inline review comments, not just issues. Originally requested as "search" only; the "_issues" suffix was added in error and persisted across iterations. Rename: - function name: `search_issues` → `search` - display title: `Search Issues` → `Search GitHub` - .mcpb manifest description / long_description: tool reference + scope phrasing - Worker tool registration (src/mcp.ts L108) + bridge dispatch (mcp-server/server/index.js L420) - error messages (src/mcp.ts L698) + comments (src/index.ts, src/mcp.ts header) - migration SQL comment (migrations/0002_fts5_rebuild.sql) - README / docs / manifest 全箇所 データ schema (D1 / Vectorize / KV) には影響なし。tool 名のみの公開インタフェース変更。 v0.x 初期開発期 (Anything may change) のため breaking 容認、patch 扱い。 Closes #126
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
github-rag-mcp | d57b0b7 | Apr 25 2026, 03:46 PM |
liplus-lin-lay
commented
Apr 25, 2026
Member
Author
liplus-lin-lay
left a comment
liplus-lin-lay
left a comment
There was a problem hiding this comment.
AI 自己レビュー (auto, patch)
仕様適合
- #126 の target_files 11 個すべて反映確認 (grep で残存 `search_issues` / `Search Issues` / `searchIssues` ゼロ)
- 関数名 / 表示名 / manifest description / Worker tool 登録 / bridge dispatch / error 文字列 / コメント / 移行 SQL コメント / README / docs 全網羅
- v0.x 初期開発期で breaking 容認、patch 判定 (`rules/operations/release-version.md` の "Anything may change" 範囲)
内容整合
- function name と display name が manifest / 内部コード / docs で一致
- Worker tool 名 (`src/mcp.ts` L108) と local bridge (`mcp-server/server/index.js` L420) を同期更新済み、protocol-level 整合性確保
- D1 / Vectorize / KV schema には未触
- manifest description は scope 拡大に合わせて "issues and PRs" → "issues, PRs, releases, docs, commit diffs, and review threads" に更新（命名と説明の semantic 整合）
自己リスク申告
- Breaking change 周知: 既存 transcript / docs に残る `search_issues` 表記を読んだ後続セッションが古い tool 名で呼び出すと 404。AI 側 tool reload で解決するが、過去 transcript の literal は不可逆
- CI 緑だが Worker 統合テスト無し: syntax check のみ通過、Worker 配備後の実機 search 動作は未検証。release/deploy 段階で要確認
- 本 session workspace の `mcp__github-rag-mcp__search_issues` tool は MCP server 再起動 (= Claude Code 再起動 + 次回 npx pull) で `mcp__github-rag-mcp__search` に切り替わる予定。現セッション中は古い名で残存
判定
auto patch self-review 承認、`gh pr merge --squash` で進める。
liplus-lin-lay
deleted the
126-tool-rename-search_issues-to-search-across-all-surfaces
branch
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
統合検索ツールの命名を実態に合わせて修正する。
search_issues→search、表示名Search Issues→Search GitHub、関連 docs / manifest / コメント / エラーメッセージも全て同期。過去に「search だけに変えて」要望があった際に「_issues」suffix が誤って残った経緯。今回完全 rename で解消。
変更内容
影響範囲
テスト
`mcp-server/npm test` (= `node --check server/index.js`) syntax check pass。Worker 側に既存テストは無し、syntax check + 既存 CI に依存。
バージョン
patch (v0.8.3 milestone)。v0.x 初期開発期で breaking 許容、scope は命名修正のみで実装ロジック変更なし。
関連