Fix grant revocation causing auth loop, add Worker debug logging#188
Merged
Conversation
新規OAuth認可時に completeAuthorization が既存grantを全削除するデフォルト動作が、 並行クライアント（MCP + WebSocketチャンネル）のgrant相互削除を引き起こしていた。 revokeExistingGrants: false で既存grant保持に変更。 tokenExchangeCallback にデバッグログ追加で grant lifecycle を可視化。 Refs #187 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
github-webhook-mcp | 3d74e18 | Apr 13 2026, 09:16 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #187
completeAuthorizationのデフォルト動作で新規認可時に既存grantを全削除していた。並行クライアント（MCP tool + WebSocketチャンネル）が同時にOAuth認証を走らせると、
一方が他方のgrantを消す → リフレッシュ失敗 → ブラウザ認可ループの原因になっていた。
revokeExistingGrants: falseで既存grant保持に変更。tokenExchangeCallbackにデバッグログ追加。