Fixed divide by zero error when calibrating MPU-6886#25
Merged
LiquidCGS merged 1 commit intoLiquidCGS:mainfrom Jul 4, 2024
Merged
Fixed divide by zero error when calibrating MPU-6886#25LiquidCGS merged 1 commit intoLiquidCGS:mainfrom
LiquidCGS merged 1 commit intoLiquidCGS:mainfrom
Conversation
Contributor
Author
|
Hey @LiquidCGS it would be great if you had some time to take a look at this PR. There is a project of mine that depends on it. |
Owner
On it! |
Owner
|
I don't have an MPU6886 to test at the moment, it's odd that this fixes it since almost that exact same code works for all the other IMU's of the same family, but hey, if it works then that's what matters. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the crash due to division by zero when calibrating the MPU6886 mentioned in #21.
The problem was most likely caused by disabling the FIFO and reading the FIFO_COUNT register in the wrong order.