Skip to content

FEAT: Rework to improve performance #1

Merged
LiquidCats merged 11 commits into
mainfrom
feat-improve-and-optimze
Oct 16, 2025
Merged

FEAT: Rework to improve performance #1
LiquidCats merged 11 commits into
mainfrom
feat-improve-and-optimze

Conversation

@LiquidCats
Copy link
Copy Markdown
Owner

@LiquidCats LiquidCats commented Oct 14, 2025

Summary

The Pull Request refactors and reorganizes the jsonrpc package by modularizing code into separate files for better maintainability, improves HTTP client configuration, and updates dependencies to newer versions. Additionally, it introduces benchmarks and more extensive test coverage for new functionality.

Main changes:

  • Refactored client.go: Removed JSON-RPC-specific logic, moved it to new files (data.go, executor.go).
  • Added data.go file: Encapsulates JSON-RPC-specific data structures and methods.
  • Added executor.go file: Handles JSON-RPC request execution, with configurable options for HTTP requests and clients.
  • Improved test coverage:
    • Added tests for the newly introduced data.go and executor.go.
    • Removed outdated tests from client_test.go and replaced them with improved tests in relevant new files.
    • Added benchmarks and goroutine-based performance tests.
  • GitHub Actions workflow update (test.yml):
    • Updated dependencies for actions/checkout and actions/setup-go.
    • Added new bench step to run benchmarks separately.
  • Updated Go module dependencies (go.mod and go.sum):
    • Updated several existing dependencies to newer versions.
    • Replaced github.com/go-faster/errors with github.com/rotisserie/eris.

This PR improves the structure, maintainability, and reliability of the jsonrpc package while keeping backward compatibility.

@LiquidCats LiquidCats merged commit 8669b15 into main Oct 16, 2025
8 checks passed
@LiquidCats LiquidCats deleted the feat-improve-and-optimze branch October 16, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant