Skip to content

Regression: SingleMatch and ShowSingleMatch on dota2 not obeying width parameter #7454

@x42bn6

Description

@x42bn6

On dota2, we sometimes use {{SingleMatch}} for single matches. This takes a width parameter as defined in Template:SingleMatch and is passed into {{ShowSingleMatch}}.

At some point between October 2025 and May 2026, the width parameter stopped being obeyed. Consider this diff, where I specifically widened the widget, and never reverted it (because it worked).

The easiest fix appears to be to change this line. I tested it in my dev module:

return MatchSummary.defaultGetByMatchId(CustomMatchSummary, args, {width = (args.width .. 'px') or '400px', teamStyle = 'bracket'})

It looks like this (which may be moved to mainspace by the time this bug report is looked at more closely). This was widened to 500px.

However, I don't really like this fix, because Module:MatchGroup/Display/SingleMatch specifically strips out the "px". But at the same time, I don't understand the Commons module well enough. (Tangentially though, would we want to support things like percentage-based widths in this module?)

Metadata

Metadata

Assignees

Labels

Type

No fields configured for Bug.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions