feat(match2): add tournament highlight to match pages#5955
Merged
Conversation
hjpalpha
reviewed
May 23, 2025
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
codewise lgtm
can you add a screenshot?
Collaborator
Author
added a link to the test page too |
hjpalpha
approved these changes
May 23, 2025
Collaborator
|
General practice is not to center something with an icon. I'm unsure if adding the highlight is a good idea. So just will likely sit open for a bit |
Collaborator
|
TLDR: |
Rathoz
changed the title
Rathoz
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds highlight (as specified by
Module:HighlightConditions) to the match page header.How did you test this change?
dev: https://liquipedia.net/leagueoflegends/Match:ID_User_ElectricalBoy_zqx7pe0nDj_R01-M001