feat(Opponent): Support apiId #6929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
lgtm for now
a better long-term solution would be adding apiId to lpdb player mapping of some sort as dota2 db moves to Crossroads, which, btw, LoLDB (mapping only) and VALDB (XRoads + mapping) already have
but that's obviously oos of Lua-Modules repo :/
ElectricalBoy
approved these changes
Dec 22, 2025
Eetwalt
approved these changes
Jan 28, 2026
Collaborator
|
If you can resolve the conflicts I'll merge this one @hjpalpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add option to set/store apiId to alow to match in-game IDs from match API to page and display names of players, see also #6843
orig report for the support to be missing via discord:
https://discord.com/channels/93055209017729024/268719633366777856/1451808363749965949
doing this in commons instead of in a dota custom because:
How did you test this change?
dev