Skip to content

fix: award blocking ppt matching#7447

Merged
Rathoz merged 3 commits intomainfrom
fix-awards-collition
Apr 30, 2026
Merged

fix: award blocking ppt matching#7447
Rathoz merged 3 commits intomainfrom
fix-awards-collition

Conversation

@Rathoz
Copy link
Copy Markdown
Collaborator

@Rathoz Rathoz commented Apr 30, 2026

Summary

Resolves #7318 by enriching all matching prizepools instead of just one.

How did you test this change?

dev

@Rathoz Rathoz marked this pull request as ready for review April 30, 2026 11:53
@Rathoz Rathoz requested a review from a team as a code owner April 30, 2026 11:53
Copilot AI review requested due to automatic review settings April 30, 2026 11:53
@Rathoz Rathoz requested a review from a team as a code owner April 30, 2026 11:53
@Rathoz Rathoz requested a review from mbergen April 30, 2026 11:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes incorrect TeamParticipants LPDB enrichment when the same team appears in multiple prizepool-derived placement records (e.g., main placement + award placement), ensuring roster/alias/qualification data is applied to all relevant records (resolving #7318).

Changes:

  • Update prizepool lookup to return all matching placement records for a team (not just the first match).
  • Store/enrich each matching LPDB placement record (including award-derived ones) during TeamParticipantsRepository.save.
  • Adjust TBD handling to return an empty list from getPrizepoolRecordForTeam.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/commons/TeamParticipants/Repository.lua
Comment thread lua/wikis/commons/TeamParticipants/Repository.lua
Comment thread lua/wikis/commons/TeamParticipants/Repository.lua Outdated
Comment thread lua/wikis/commons/TeamParticipants/Repository.lua Outdated
@Rathoz Rathoz requested a review from mbergen April 30, 2026 12:33
Comment thread lua/wikis/commons/TeamParticipants/Repository.lua
@Rathoz Rathoz force-pushed the fix-awards-collition branch from 752ffd5 to 1953c49 Compare April 30, 2026 12:42
Comment thread lua/wikis/commons/TeamTemplate.lua
@Rathoz Rathoz force-pushed the fix-awards-collition branch from 1953c49 to 5705a0b Compare April 30, 2026 13:02
@Rathoz Rathoz merged commit c3c68fd into main Apr 30, 2026
7 checks passed
@Rathoz Rathoz deleted the fix-awards-collition branch April 30, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TeamParticipants not storing placement data when award placement exists

3 participants