Skip to content

try to resolve comment#7457

Merged
hjpalpha merged 8 commits intoclubshare-vrsfrom
resolve-comment-of-7284
May 7, 2026
Merged

try to resolve comment#7457
hjpalpha merged 8 commits intoclubshare-vrsfrom
resolve-comment-of-7284

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented May 4, 2026

Copy link
Copy Markdown
Collaborator

@MischiefCS MischiefCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes allow it to work as shown here

https://liquipedia.net/counterstrike/User:MischiefCS/PGL/2025/Astana

However moving logic from PrizePool/Base to PrizePool/Placement will no longer allow the usage of localcurrency in the clubShare calcs so theres no way to get it from the auto-exchange of the local currency.

If the logic flow is wanted in Placement/Base its not a huge issue as 99% of all clubShare applications are dollars.

Comment thread lua/wikis/commons/PrizePool/Placement/Base.lua Outdated
Comment thread lua/wikis/commons/PrizePool/Placement/Base.lua Outdated
@hjpalpha
Copy link
Copy Markdown
Collaborator Author

hjpalpha commented May 7, 2026

However moving logic from PrizePool/Base to PrizePool/Placement will no longer allow the usage of localcurrency in the clubShare calcs so theres no way to get it from the auto-exchange of the local currency.

because thematically it belongs there

@hjpalpha
Copy link
Copy Markdown
Collaborator Author

hjpalpha commented May 7, 2026

adjusted it so that it should work with local currency too, needs testing

@hjpalpha hjpalpha requested a review from MischiefCS May 7, 2026 14:32
@MischiefCS
Copy link
Copy Markdown
Collaborator

adjusted it so that it should work with local currency too, needs testing

appears to work when tested https://liquipedia.net/counterstrike/User:MischiefCS/PGL/2025/Astana

@MischiefCS MischiefCS marked this pull request as ready for review May 7, 2026 17:15
@MischiefCS MischiefCS requested review from a team as code owners May 7, 2026 17:15
@hjpalpha hjpalpha merged commit d8a442c into clubshare-vrs May 7, 2026
8 checks passed
@hjpalpha hjpalpha deleted the resolve-comment-of-7284 branch May 7, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants