feat: in team participants, do not set pagevars for DNP players#7483
Merged
Conversation
hjpalpha
approved these changes
May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TeamParticipants repository logic so that players marked as DNP (i.e., extradata.results == false/nil) no longer have page variables set for them, aligning pagevar output with the existing “only count players with results” behavior used for LPDB placement storage.
Changes:
- Introduced a shared
shouldStorePlayer(player)predicate to centralize the “counts for results” check. - Reused the predicate when filtering opponent players for LPDB placement data generation.
- Updated
setPageVars()to skip setting pagevars for players that should not be counted for results (DNP).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?