refactor: make mergeProps more efficient (at cost of mutating)#7487
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors ColumnUtil.mergeProps in the Table2 widget to avoid creating a separate merged props table, instead mutating the passed-in cell/header props for improved efficiency.
Changes:
- Refactored
ColumnUtil.mergePropsto mutatecellPropsand introduced a sharedINHERITABLE_PROPSlist. - Updated Table2
CellandCellHeaderto rely on mutatedpropsinstead of a returned merged table. - Simplified the call sites by removing the intermediate
mergedPropsvariable.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/wikis/commons/Widget/Table2/ColumnUtil.lua | Refactors prop merging to mutate input props and centralizes inheritable prop keys. |
| lua/wikis/commons/Widget/Table2/CellHeader.lua | Adjusts header rendering to use mutated props after merging. |
| lua/wikis/commons/Widget/Table2/Cell.lua | Adjusts cell rendering to use mutated props after merging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
More efficient, but mutates. However many of the other functions in the same util also mutates the inputs.
Also fixes https://discord.com/channels/93055209017729024/372075546231832576/1503394166829224046
How did you test this change?
dev