feat(TeamParticipants): ommit ingame role display for roles without icon

[hjpalpha]

depends on #7529

Summary

• only display ingame roles if they have an icon
• for non ingame roles display icon if available, use current display if no icon is available
• fix a missing anno

How did you test this change?

dev

[hjpalpha]

if this is liked i can go through the ingame roles and add the iconFa for igl/captain where those exist

[Rathoz]

Medium term captain (and similiar) should not be in ingameroles. Ingame roles should only be actual game based positions. So based on current plans this adds tech debt for a small short-term gain

[mbergen]

Medium term captain (and similiar) should not be in ingameroles. Ingame roles should only be actual game based positions. So based on current plans this adds tech debt for a small short-term gain

That's what i suggested in the linked issue (#7491). In which set of roles would captain belong, a new one?

[hjpalpha]

Medium term captain (and similiar) should not be in ingameroles. Ingame roles should only be actual game based positions. So based on current plans this adds tech debt for a small short-term gain

the only debt we create with this pr is adding the ingame roles modules for sc, sc2, sg
the rest is independent of captain being an ingame role or not

i am okay with creating a fourth role type for it, but don't have a good name for it
(fwiw teamParticipants would need some small adjusts for that if we want to display them as icon)

adding captain to staff roles or contract roles is way way way worse than having them in ingame roles
it would break quite some stuff and also fuck up teamParticipants storage for anyone with those roles (would be stored as staff instead of player which is just completely wrong)

[Eetwalt]

i am okay with creating a fourth role type for it, but don't have a good name for it
(fwiw teamParticipants would need some small adjusts for that if we want to display them as icon)

I think in this PR we can just leave the parts in which don't display the text on the left, only icons.
And make another one suggesting a fourth role category. Name candidates for this category could be PlayerRole as salt suggested, TeamRole or even PlayerTeamRole ?

[hjpalpha]

i am okay with creating a fourth role type for it, but don't have a good name for it
(fwiw teamParticipants would need some small adjusts for that if we want to display them as icon)

I think in this PR we can just leave the parts in which don't display the text on the left, only icons. And make another one suggesting a fourth role category. Name candidates for this category could be PlayerRole as salt suggested, TeamRole or even PlayerTeamRole ?

hmm,
will split it up into 3 PRs when i find the time

• kick ingame role display in TeamParticipants that don't have icon (because it just looks shit) feat(TeamParticipants): ommit ingame role display for roles without icon #7523
• add option for icons in roles data (prereq for 3rd PR and generally usefull imo) feat(Roles): add option for icon data in role datas #7528
• add 4th role type and set up a base version of that data on commons (with only captain and igl) feat(Roles): implement PlayerTeamRoles #7529