Conversation
ElectricalBoy
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Wild Rift-specific Legacy TeamCard wrapper that backfills missing lane/role positions based on slot order, ensuring older TeamCard pages render role icons correctly under the Legacy wrapper.
Changes:
- Added
lua/wikis/wildrift/TeamCard/Legacy/Custom.luato preprocess legacy card args and defaultpNposusingModule:InGameRoles.sortOrder. - Extended
lua/wikis/wildrift/InGameRoles.luarole entries withsortOrderto support deterministic slot-to-role defaulting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/wikis/wildrift/TeamCard/Legacy/Custom.lua | Adds a Wild Rift legacy wrapper that defaults missing pNpos values by slot index using in-game role ordering. |
| lua/wikis/wildrift/InGameRoles.lua | Adds sortOrder metadata to Wild Rift in-game roles to support ordering-dependent consumers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rathoz
reviewed
Jun 1, 2026
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Module:TeamCard/Legacy/Customfor wildrift, mirroring the LoL custom mapping: defaultspNposby slot index viaModule:InGameRolessortOrderso old TC pages without explicit lane positions still render icons under the Legacy wrapper.sortOrderfields toModule:InGameRoles(baron=1, jungle=2, mid=3, dragon=4, support=5) so the slot-to-lane defaulting has data to read.How did you test this change?
dev (live in prod)