Feature/joins #22
Merged
Feature/joins #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full,inner,left,right joins
LissaGreense
approved these changes
Oct 8, 2024
Owner
LissaGreense
left a comment
LissaGreense
left a comment
There was a problem hiding this comment.
Awesome feature! :D Let's go!
ixior462
added a commit
that referenced
this pull request
Jan 17, 2025
* e2e version matrix update * Refactor that makes code shiny * Fix parser test pointer * Final refactor - improve select structure * Fix delete command * Add Drop Function * Add error handling for parser * second part of error handling * Adds LIMIT and OFFSET keywords :D * Add Update command * Feature/error handling tests (#20) * Parser error handling wip * Add error handling for engine and finish parser --------- Co-authored-by: LissaGreense <walissa13@gmail.com> * Add Distinct select implementation (#21) * Feature/joins (#22) JOIN FEATURE * Add full join implementation * Add full join error handling tests in engine * Add documentation, lexer, parser and only tests for engine, handling full,inner,left,right joins * Add enginge implemenatation and e2e tests for full,inner,left and right joins * Refactore join method * Aggregate functions (#23) * Add Aggregate function handling in lexer, parser and even write documentation * Aggregate functions engine WIP * Finish tests, fix implementation of aggr functions --------- Co-authored-by: ixior462 <pawel.krupski@mail.com> * Feature - "IN" and "NOTIN" condition (#24) * Parser, lexer, token and ast impl * engine, parser err handling, readme, tests for IN * Feature/null insertion (#25) * Tokens have been added * Parser and lexer logic has been updated. * Introduced a new section in README 'supported types' * Add engine integration with NULL values --------- Co-authored-by: LissaGreense <walissa13@gmail.com> * Add apostrophe validation errors (#26) * Add gopher to README.md (#28) * Refactore e2e tests (#27) * Refactore e2e tests structure * Update README in E2E section * Move e2e test to seperate file * Feature - apostrophe error validate (#29) * Add apostrophe validation errors * refactor * Rewrite getExpression logic --------- Co-authored-by: LissaGreense <walissa13@gmail.com> Co-authored-by: Sara Ryfczyńska <s.ryfczynska@gmail.com>
ixior462
added a commit
that referenced
this pull request
May 23, 2025
* e2e version matrix update * Refactor that makes code shiny * Fix parser test pointer * Final refactor - improve select structure * Fix delete command * Add Drop Function * Add error handling for parser * second part of error handling * Adds LIMIT and OFFSET keywords :D * Add Update command * Feature/error handling tests (#20) * Parser error handling wip * Add error handling for engine and finish parser --------- * Add Distinct select implementation (#21) * Feature/joins (#22) JOIN FEATURE * Add full join implementation * Add full join error handling tests in engine * Add documentation, lexer, parser and only tests for engine, handling full,inner,left,right joins * Add enginge implemenatation and e2e tests for full,inner,left and right joins * Refactore join method * Aggregate functions (#23) * Add Aggregate function handling in lexer, parser and even write documentation * Aggregate functions engine WIP * Finish tests, fix implementation of aggr functions --------- * Feature - "IN" and "NOTIN" condition (#24) * Parser, lexer, token and ast impl * engine, parser err handling, readme, tests for IN * Feature/null insertion (#25) * Tokens have been added * Parser and lexer logic has been updated. * Introduced a new section in README 'supported types' * Add engine integration with NULL values --------- * Add apostrophe validation errors (#26) * Add gopher to README.md (#28) * Refactore e2e tests (#27) * Refactore e2e tests structure * Update README in E2E section * Move e2e test to seperate file * Feature - apostrophe error validate (#29) * Add apostrophe validation errors * refactor * Rewrite getExpression logic --------- Co-authored-by: LissaGreense <walissa13@gmail.com> Co-authored-by: Sara Ryfczyńska <s.ryfczynska@gmail.com>
ixior462
added a commit
that referenced
this pull request
May 23, 2025
* e2e version matrix update * Refactor that makes code shiny * Fix parser test pointer * Final refactor - improve select structure * Fix delete command * Add Drop Function * Add error handling for parser * second part of error handling * Adds LIMIT and OFFSET keywords :D * Add Update command * Feature/error handling tests (#20) * Parser error handling wip * Add error handling for engine and finish parser --------- Co-authored-by: LissaGreense <walissa13@gmail.com> * Add Distinct select implementation (#21) * Feature/joins (#22) JOIN FEATURE * Add full join implementation * Add full join error handling tests in engine * Add documentation, lexer, parser and only tests for engine, handling full,inner,left,right joins * Add enginge implemenatation and e2e tests for full,inner,left and right joins * Refactore join method * Aggregate functions (#23) * Add Aggregate function handling in lexer, parser and even write documentation * Aggregate functions engine WIP * Finish tests, fix implementation of aggr functions --------- Co-authored-by: ixior462 <pawel.krupski@mail.com> * Feature - "IN" and "NOTIN" condition (#24) * Parser, lexer, token and ast impl * engine, parser err handling, readme, tests for IN * Feature/null insertion (#25) * Tokens have been added * Parser and lexer logic has been updated. * Introduced a new section in README 'supported types' * Add engine integration with NULL values --------- Co-authored-by: LissaGreense <walissa13@gmail.com> * Add apostrophe validation errors (#26) * Add gopher to README.md (#28) * Refactore e2e tests (#27) * Refactore e2e tests structure * Update README in E2E section * Move e2e test to seperate file * Feature - apostrophe error validate (#29) * Add apostrophe validation errors * refactor * Rewrite getExpression logic * Refactor and improvements (#31) * Upgrade go version and fix issues from Go Report Card * Fix errorhandling tests * Resolve go report card feed * Refactore engine functions * Change getSelectResponse function * Refactor select response logic * Improve comments --------- Co-authored-by: ixior462 <pawel.krupski@mail.com> --------- Co-authored-by: ixior462 <pawel.krupski@mail.com> Co-authored-by: Paweł Krupski <34219324+ixior462@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.