You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been checking open PRs by building the branch and running it against a test harness rather than by reading the diff, and I would rather ask whether that helps than keep guessing.
The harness generates a synthetic audiobook library from public-domain metadata and drives a real container through the API, so it answers things a diff cannot. Three recent examples:
It seems to be landing with the people whose PRs I commented on. dny238 revised #784 and #781 off the back of it, and t3chnaztea folded the #756 finding into that PR's description. What I do not know is whether it helps you, which is the part that matters, since you are the one who has to merge any of it.
So, two questions, and a one-line answer to either is plenty. Is this useful, or is it just more to read? And if it is useful, is there anything you would rather I pointed it at than whatever I happen to pick?
I have twenty comments across seventeen threads now, most of them in the last few days, and I would rather stop than add noise while you are heads-down. I have also stayed out of #717's area unless something looked like it would collide with it, on the assumption you do not want that branch disturbed. Say if that is backwards.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
I have been checking open PRs by building the branch and running it against a test harness rather than by reading the diff, and I would rather ask whether that helps than keep guessing.
The harness generates a synthetic audiobook library from public-domain metadata and drives a real container through the API, so it answers things a diff cannot. Three recent examples:
AutomaticSearchService, which runs on a timer rather than only on a user-initiated searchIt seems to be landing with the people whose PRs I commented on. dny238 revised #784 and #781 off the back of it, and t3chnaztea folded the #756 finding into that PR's description. What I do not know is whether it helps you, which is the part that matters, since you are the one who has to merge any of it.
So, two questions, and a one-line answer to either is plenty. Is this useful, or is it just more to read? And if it is useful, is there anything you would rather I pointed it at than whatever I happen to pick?
I have twenty comments across seventeen threads now, most of them in the last few days, and I would rather stop than add noise while you are heads-down. I have also stayed out of #717's area unless something looked like it would collide with it, on the assumption you do not want that branch disturbed. Say if that is backwards.
The harness is at https://github.com/m4bard/listenarr-testdata and everything above is reproducible from it. No reply needed if the answer is "not now".
All reactions