Allow HTTP URLs for notification webhooks#555
Merged
therobbiedavis merged 5 commits intoListenarrs:canaryfrom May 1, 2026
Merged
Allow HTTP URLs for notification webhooks#555therobbiedavis merged 5 commits intoListenarrs:canaryfrom
therobbiedavis merged 5 commits intoListenarrs:canaryfrom
Conversation
therobbiedavis
added
the
minor
therobbiedavis
requested changes
Apr 29, 2026
Collaborator
There was a problem hiding this comment.
@lhanson Simple and easy. Thanks! However we currently do not have any tests for this, could you add regression coverage for this in NotificationsTab.spec.ts? That spec currently only covers the loading state, so the URL scheme behavior is untested.
Suggested cases:
- accepts
https://ntfy.tld.com/topic - accepts
http://ntfy.local/topic - rejects a non-HTTP(S) scheme such as
ftp://ntfy.local/topic
That would prove the reported LAN/self-hosted webhook case and guard against accidentally restoring HTTPS-only validation later.
Contributor
Author
|
Test cases added, thanks for those suggestions. |
Collaborator
|
@lhanson Can you rebase this? There is now a rebase conflict so I can not do it from my side unless I commit it myself. Thanks! |
Collaborator
|
@lhanson The unit test is failing. |
Contributor
Author
|
Should be fixed now. |
therobbiedavis
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #545
Changes
Changed