Add list view for grouped author/series in audiobooks library#585
Draft
kevinheneveld wants to merge 1 commit into
Draft
Add list view for grouped author/series in audiobooks library#585kevinheneveld wants to merge 1 commit into
kevinheneveld wants to merge 1 commit into
Conversation
The audiobooks toolbar exposes a list/grid toggle, but the grouped view template only rendered a grid — toggling to list mode while grouped by author or series was silently ignored. The list template only existed inside the `groupBy === 'books'` branch. This adds a parallel list rendering for grouped collections: - Row per collection (cover thumb, name, book count) - Clicking a row navigates to the collection page (matches grid behavior) - Keyboard accessible (Enter / Space activate the row) CSS reuses the existing `.audiobooks-list` / `.audiobook-list-item` patterns; the row layout has its own three-column grid template (cover / name / count) since collection rows don't carry status badges or per-item actions. Tests added for both authors and series groupings in list mode.
3 tasks
Contributor
|
Small note regarding the issue linked to this: Is there a particular reason why you created it on the fork instead of here ? It might be better to open them here instead if you expect feedback on those (or perhaps there is a way to see forked repository issues from here ?) |
Author
|
Good point. My workflow tracks issues on the fork as a working backlog, but you're right that anything expecting upstream feedback belongs here. I'll re-open this one on Listenarrs/Listenarr and relink it. |
Author
|
Re-filed the linked issue here: #595 (was kevinheneveld#1). Will update the PR body to point at the new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?group=authors,?group=series) only had a grid template. Toggling list mode while grouped was silently a no-op.?group=books) was already correct and is unchanged.Implementation notes
fe/src/views/library/AudiobooksView.vue. The existing grid is now wrapped inv-else, with the newv-if="viewMode === 'list'"branch above it..audiobooks-list/.audiobook-list-itempatterns; collection rows have their own three-column grid template (cover / name / count) since they don't carry status badges or per-item actions.showItemDetailsis treated as a no-op for collection list rows — the book count is the primary metadata for a collection and is always visible.viewModeandtoggleViewModeare exposed viadefineExposeso the new tests can drive the view deterministically.Test plan
cd fe && npm run test:unit— 350 / 350 passing (includes 2 new parameterized cases for authors + series list mode)npx vue-tsc --noEmit -p tsconfig.app.json— cleancd tests && dotnet test— 613 / 613 passing (no backend changes; sanity)Closes #595