Allow qBittorrent to determine hash ahead of time to avoid association errors#610
Merged
Merged
Conversation
therobbiedavis
requested changes
May 23, 2026
Collaborator
therobbiedavis
left a comment
therobbiedavis
left a comment
There was a problem hiding this comment.
Looks good for the most part. We need to clean up dead code, and I had a question about BencodeNET
therobbiedavis
requested changes
May 26, 2026
Collaborator
therobbiedavis
left a comment
therobbiedavis
left a comment
There was a problem hiding this comment.
Great job, I still have some hesitation around the cookies and url only torrent adds but I think this is looking better.
Sidenote: Let's make sure we don't commit an impermissible torrent to the repo 😆
T4g1
force-pushed
the
fix/609-qbittorrent-hash
branch
from
0361f69 to
85aba51
Compare
therobbiedavis
requested changes
May 27, 2026
T4g1
force-pushed
the
fix/609-qbittorrent-hash
branch
from
cd51f91 to
aff1c48
Compare
T4g1
force-pushed
the
fix/609-qbittorrent-hash
branch
from
aff1c48 to
c4c6fb0
Compare
therobbiedavis
approved these changes
May 28, 2026
|
|
||
| private async Task<HttpResponseMessage> DoAdd(HttpRequestMessage request, CancellationToken ct) | ||
| { | ||
| if (!Authenticated) |
Collaborator
There was a problem hiding this comment.
Optional: The current mock accepts add requests based on a global Authenticated flag, so the tests verify login ordering but not the new cookie-propagation behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows two reports of association errors on Discord support channel
Changes
Changed
Testing
Notes
As i was not able to reproduce the issue discussed on Discord (association errors when adding torrents to qBittorrent), this might not solve the real issue but it should be an improvement nonetheless