Skip to content

Refact and tuning#68

Merged
wada-at-live2d-com merged 6 commits intoLive2D:developfrom
ppcuni:refact_and_tuning
Apr 5, 2023
Merged

Refact and tuning#68
wada-at-live2d-com merged 6 commits intoLive2D:developfrom
ppcuni:refact_and_tuning

Conversation

@ppcuni
Copy link
Copy Markdown
Contributor

@ppcuni ppcuni commented Feb 4, 2023

Fixed a noticeable performance impact when running in Unity. Please check.

Evaluate_before
CubismPhysicsSubRig Evaluate_before

Evaluate_after
CubismPhysicsSubRig Evaluate_after

UpdateBlendColors_before
CubismRenderController UpdateBlendColors_before

UpdateBlendColors_after
CubismRenderController UpdateBlendColors_after

OnDynamicDrawableData_before
CubismRenderController OnDynamicDrawableData_before

OnDynamicDrawableData_after
CubismRenderController OnDynamicDrawableData_after

Temporary buffers when applying multiply and screen colors to CubismRenderer should not be re-created every frame.
@wada-at-live2d-com
Copy link
Copy Markdown
Contributor

wada-at-live2d-com commented Mar 17, 2023

Hi, @ppcuni

Sorry for the delay in getting back to you.

We have confirmed that the content of this correction is correct and that it works correctly, and we would like to incorporate it into the product.

We would like to ask for additional confirmation or correction of the following points.

  • Regarding the modification of CubismRenderController, there is a place where backing field _renderers is called as it is, so please use the property Renderers unless there is a special reason.
  • Please move the variable between the backing field _renderers and the property Renderers, since it is defined there.

@wada-at-live2d-com wada-at-live2d-com merged commit 43494ee into Live2D:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants