Use after free in settings editor

[CryZe]

1. Open the settings editor
2. Edit a hotkey
3. Close it with OK
4. Reopen it
5. Edit a hotkey
6. An uncaught "this is disposed" exception is thrown.

[CryZe]

This might be one of those "React remounts a component without constructing a new one" issues.

[wooferzfg]

Am I doing something wrong? I'm not sure how to reproduce this.

[CryZe]

Seems like it's rather editing a hotkey, closing it with OK, reopening it and then editing a hotkey again? At least that's how I can trigger it atm. Original description doesn't seem to work.

[wooferzfg]

@CryZe Which version of livesplit-core are you using?

[CryZe]

This is with the published https://one.livesplit.org i.e. whatever version master is using. I believe you may not be seeing this because it's not a production build? (and therefore it may not reuse components as aggressively?)

[wooferzfg]

I was able to reproduce this on the published site and on the dev server: