You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's some general feedback from Copilot, idk how much of this makes sense:
“自己ベスト” vs “ベストタイム”: Rust consistently uses “自己ベスト” for PB, while TS uses “ベストタイム” in the save prompt. Compare japanese.ts:72-73 with japanese.rs:515-516.
“得失タイム” vs “短縮/ロスタイム”: Rust labels gained/lost time as “得失タイム”, while TS uses “短縮/ロスタイム” for the column label. Compare japanese.rs:225 with japanese.ts:277-278.
“リード/遅れ” vs “リード/遅れタイム”: Rust typically uses “リード/遅れ” without “タイム”, while TS has the column label “リード/遅れタイム”. Compare japanese.rs:29 with japanese.ts:274-275.
As a term encompassing not only personal best but also segment bests, japanese.ts:72-73 uses ベストタイム.
得失タイム and 短縮/ロスタイム are interpreted as having the same meaning; the difference in the highlighted section stems from retaining the original translation's phrasing.
I believe it's sufficient as long as it's consistent within a single component, so I think it's fine as is.
The presence or absence of タイム follows the original translation.
In japanese.rs:29, it appears within a sentence. Given the context of a timer app, it can be correctly interpreted even without タイム and remains natural in Japanese.
In japanese.ts:274-275, this word is used alone. While it can still be correctly interpreted without タイム, I feel that including タイム makes it more appropriate as the name of a selection option.
Alright, CI should pass in a few minutes and then it should auto merge and publish. Thank you so much for the time and effort that you put into this, I really appreciate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1119