refactor: token初始化方式及Readme文档修改#6
Open
metaimagine wants to merge 4 commits into
Open
Conversation
1.token初始化方式改为env，便于提交代码时隔离token问题，且有助于后续扩展多llm的配置 2.Readme做部署相关对应内容补充
Owner
|
nice work~ 有一些内容需要讨论一下： |
Author
|
了解，改用统一配置这一点我们应该不用讨论了。主要是隔离方式，其实这个是老生常谈的问题。 假设个场景，我单次commit会改写了很多内容涉及多个文件，（我）习惯上会直接 若用ignore+env的方式隔离，其实就麻烦一开始，后面都会很舒服，完全不用担心pull或者add时缓冲区env文件的变动影响。 |
Owner
|
刚刚测试了一下，其实没必要引入env，直接.gitignore里配置一下token.py就可以避免被提交了，如果配置之后没用，则是因为没有清除缓存 |
Author
|
那后续token.py的内容有变动的话（例如多个其他llm的token配置），那得再改.gitignore提交嘛？感觉很麻烦欸，然后还得再改回来。 |
Owner
|
后续验证了一下，似乎只有新建的文件才能避免被跟踪，这样似乎又麻烦了起来 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.token初始化方式改为env，便于提交代码时隔离token问题，且有助于后续扩展多llm的配置
2.Readme做部署相关对应内容补充