Skip to content

fix(docker)!: move DOCKER_HUB_USERNAME from secrets to input #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Feb 14, 2026
Merged

fix(docker)!: move DOCKER_HUB_USERNAME from secrets to input #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/__call-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ on:
pull_request:
workflow_call:
inputs:
docker_hub_username:
description: 'Docker Hub username to use for the workflow.'
required: false
type: string
gh_bot_name:
description: 'GitHub bot name to use for the workflow.'
required: false
Expand All @@ -42,9 +46,6 @@ on:
required: true
type: string
secrets:
DOCKER_HUB_USERNAME:
description: 'Docker Hub username to use for the workflow.'
required: false
DOCKER_HUB_PASSWORD:
description: 'Docker Hub password to use for the workflow.'
required: false
Expand Down Expand Up @@ -257,7 +258,7 @@ jobs:
if: inputs.publish_release == 'true' # PRs do not have access to secrets
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
with:
username: ${{ secrets.DOCKER_HUB_USERNAME }}
username: ${{ inputs.docker_hub_username }}
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}

- name: Log in to the Container registry
Expand Down Expand Up @@ -350,7 +351,7 @@ jobs:
- name: Update Docker Hub Description
uses: peter-evans/dockerhub-description@1b9a80c056b620d92cedb9d9b5a223409c68ddfa # v5.0.0
with:
username: ${{ secrets.DOCKER_HUB_USERNAME }}
username: ${{ inputs.docker_hub_username }}
password: ${{ secrets.DOCKER_HUB_PASSWORD }} # token is not currently supported
repository: ${{ needs.check_dockerfiles.outputs.base_tag }}
short-description: ${{ github.event.repository.description }}
Expand Down