Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 93.12% 92.27% -0.85%
==========================================
Files 34 34
Lines 2123 2123
Branches 1086 1086
==========================================
- Hits 1977 1959 -18
- Misses 82 92 +10
- Partials 64 72 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Add runtime guards in tests/unit/windows/test_win_display_device_hdr.cpp: skip the GetSetHdrStates test if no displays are available or if setting an extended topology fails. Replace hard ASSERT_TRUE topology check with conditional GTEST_SKIP_ to avoid failing on systems that don't support extended topologies.
ReenigneArcher
force-pushed
the
ci/replace-usbmmidd_v2
branch
from
d6d3da9 to
e24994c
Compare
Replace the previous ParsecVDisplay portable download/start in the CI workflow with a new PowerShell script (scripts/parsec-vdd.ps1) that P/Invokes Win32 setupapi/kernel32 to add virtual displays and run a keepalive loop so the driver doesn't unplug them after ~1s. Update the workflow (.github/workflows/ci.yml) to launch the script with DisplayCount=2 and wait briefly for registration. Also tighten a unit test (tests/unit/windows/test_win_display_device_hdr.cpp) to ASSERT that setTopology succeeds instead of skipping when it fails.
ReenigneArcher
force-pushed
the
ci/replace-usbmmidd_v2
branch
from
e378368 to
413ce3b
Compare
Add enumeration and display-mode APIs to parsec-vdd.ps1 and set distinct resolutions for Parsec virtual displays so Windows can distinguish otherwise-identical VDDs for topology operations. Implements DISPLAY_DEVICE/DEVMODE structs, EnumDisplayDevicesA and ChangeDisplaySettingsExA P/Invoke calls, GetParsecDisplayNames and SetResolution helpers, and a short wait + resolution-assignment loop (cycles 1920x1080, 1280x720, 1600x900 @60Hz). Also log results of each change. Update CI workflow sleep from 5s to 10s to allow time for displays to be added, resolutions set, and registered by Windows.
ReenigneArcher
force-pushed
the
ci/replace-usbmmidd_v2
branch
2 times, most recently
from
241c60f to
710ff55
Compare
Replace the Parsec VDD setup with virtual-display-rs in the CI workflow: download and extract the virtual-display-rs release, install the MSI via msiexec, and invoke a new PowerShell helper. Remove the old scripts/parsec-vdd.ps1 helper and add scripts/virtual-display-rs.ps1 which configures distinct virtual monitor modes and sends a DriverNotify payload over the driver's named pipe (no keepalive required). Adjusted the CI PowerShell invocation and shortened the post-install wait time.
ReenigneArcher
force-pushed
the
ci/replace-usbmmidd_v2
branch
from
710ff55 to
83dd56f
Compare
Replace MSI-based installation with the portable virtual-display-rs package in CI. The workflow now downloads the portable zip and nefconw.exe, extracts the driver, trusts its certificate, copies the VirtualDisplayDriver.dll into System32\drivers\UMDF, imports the provided registry entries, and creates the device node using nefconw. Removes the previous msiexec installation steps to support a portable CI-friendly installation method.
Switches JSON serialization to PowerShell's ConvertTo-Json for Windows PowerShell 5.1 compatibility and makes monitor objects ordered for consistent output. Normalizes the modes array to use an ordered hashtable for each mode. Replaces a single blocking pipe connect with a retry loop (30s deadline, 2s backoff, 2s per-attempt connect timeout), adds informative logging, and returns a non-zero exit on timeout.
CI: download both the portable and installer zips for virtual-display-rs, extract them to distinct paths, and install the driver via the installer package. The workflow now uses the installer DriverCertificate.cer (added to Root and TrustedPublisher) and pnputil to add/install the .inf instead of manually copying the DLL and importing registry entries. Also adjusted downloaded filenames and log messages for clarity.
ReenigneArcher
force-pushed
the
ci/replace-usbmmidd_v2
branch
from
003cd8f to
2103d8f
Compare
Remove the Windows-specific "Prepare tests" step from the CI workflow and delete scripts/virtual-display-rs.ps1. This removes the logic that downloaded and installed the virtual-display-rs driver (portable and installer zips), trusted the driver certificate, installed the driver and device node, started the control app, and configured virtual displays via the PowerShell script. Simplifies CI by no longer setting up virtual displays on Windows runners.
|
This was referenced Mar 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove virtual display installation from CI. Tried a few different ones, without any success.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage