Skip to content

fix: Add package-config & asset filtering to include in gh-pages#34

Merged
ReenigneArcher merged 2 commits into
masterfrom
fix/gh-pages/include-dist
May 17, 2026
Merged

fix: Add package-config & asset filtering to include in gh-pages#34
ReenigneArcher merged 2 commits into
masterfrom
fix/gh-pages/include-dist

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher commented May 17, 2026

Description

We need direct download links for release assets which doesn't work if the assets are not in gh-pages.

Additionally, gh-pages does not allow distribution over 1GB so we will selectively include what we need. This limitation also destroys the purpose of keeping all the assets in the dist branch, so this is also now reduced to include selective assets.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher force-pushed the fix/gh-pages/include-dist branch from 7831386 to 8812b4e Compare May 17, 2026 00:48
Introduce packages.config.json and package-config.js to control which release assets are mirrored (wildcard patterns, per-repo include lists). Update sync-assets.js to honor the config: only configured assets are downloaded, stored assets excluded by the config are cleaned up, hash sidecar handling improved, and new helpers added (cleanup, hash/file helpers, download limit checks). Enhance generate-packages.js to normalize GitHub metadata, build packages.json from metadata (with stats), and export helper functions. Remove the standalone sync-release-assets workflow and consolidate asset sync and pages publishing in update-pages.yml (adds scheduled runs, artifact preparation, and updated checkout/worktree logic). Update README and the gh-pages client to reference the published packages.json path. Add example packages.config.json.
@ReenigneArcher ReenigneArcher force-pushed the fix/gh-pages/include-dist branch from 8812b4e to 801b1d3 Compare May 17, 2026 01:06
Replace the packagesPaths array/fallback logic with a single packagesPath and inline fetch. Removed the fetchPackagesJson method and updated loadRepositoryData to fetch this.packagesPath directly, validating response.ok and parsing JSON. This simplifies the code by removing the raw GitHub fallback and centralizing the packages.json request.
@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher changed the title fix(gh-pages): include dist fix: Add package-config & asset filtering to include in gh-pages May 17, 2026
@ReenigneArcher ReenigneArcher merged commit d0bdd0c into master May 17, 2026
13 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/gh-pages/include-dist branch May 17, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant