.github: add shellcheck to common-lint workflow

[ReenigneArcher]

Is there an existing issue for this item?

• I have searched the existing issues

Repositories

LizardByte/.github

Languages/Skills/Technologies

Bash/Shell/Scripting, GitHub actions

Description

I'd like to add shell-check to our common-lint workflow.

One option could be to parse the yaml workflow files (and action.yml), and extract the "run" keys, then perform shell-check on the value of each. We would also need to ensure that the "shell" key is defined.

This could be an opportunity to ensure other parts of the workflows are also defined such as "concurrency", "name", etc.

Additionally, it would be good to run shell-check against any .sh files found in each repo.

Estimated Effort

effort:Extra-Large

Priority

priority:Low

Target Milestone

6+ months

Dependencies

No response

[ReenigneArcher]

This will be easier than I originally thought.

https://github.com/rhysd/actionlint

We can reference what homebrew does as well. May need to sed to replace some odd shells like the freebsd or msys2 shells: https://github.com/Homebrew/homebrew-core/blob/9c309ed1887ce14f3eb1843894ed2f2f0da410ec/.github/workflows/actionlint.yml

Note: Apparently we can also upload the results as a sarif file.