Skip to content

fix(linux): migrate to qt tray#104

Open
ReenigneArcher wants to merge 5 commits intomasterfrom
fix/linux/migrate-to-qt-tray
Open

fix(linux): migrate to qt tray#104
ReenigneArcher wants to merge 5 commits intomasterfrom
fix/linux/migrate-to-qt-tray

Conversation

@ReenigneArcher
Copy link
Member

Description

Migrate to qt5/6 for Linux tray.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 73.72263% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.40%. Comparing base (98a0a39) to head (aff9e33).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/tray_linux.cpp 73.72% 13 Missing and 23 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   73.06%   74.40%   +1.33%     
==========================================
  Files           4        4              
  Lines         427      422       -5     
  Branches       83      111      +28     
==========================================
+ Hits          312      314       +2     
+ Misses         72       63       -9     
- Partials       43       45       +2     
Flag Coverage Δ
Linux 63.12% <73.72%> (+3.12%) ⬆️
Windows 71.56% <ø> (ø)
libappindicator3-dev ?
libayatana-appindicator3-dev ?
macOS 64.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/example.c 0.00% <ø> (ø)
src/tray_linux.cpp 73.72% <73.72%> (ø)

@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 3 times, most recently from 5c51030 to 55d2fb6 Compare March 24, 2026 01:24
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 3 times, most recently from a84acf6 to f357f00 Compare March 24, 2026 02:35
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch from f357f00 to c4b0b6e Compare March 24, 2026 02:49
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch 4 times, most recently from f24fd24 to 8341803 Compare March 24, 2026 03:31
@ReenigneArcher ReenigneArcher force-pushed the fix/linux/migrate-to-qt-tray branch from 8341803 to aff9e33 Compare March 24, 2026 03:39
@sonarqubecloud
Copy link

@github-actions
Copy link

Screenshot Comparison

PR #104 screenshots vs screenshots baseline.

Matrix: Linux

Image Baseline PR
tray_icon_initial.png
tray_icon_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png
tray_notification_themed_icon.png

Matrix: Linux-libappindicator3-dev

Image Baseline PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

Matrix: Linux-libayatana-appindicator3-dev

Image Baseline PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

Matrix: Windows

Image Baseline PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

Matrix: macOS

Image Baseline PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant