fix(linux): break QtMainLoop on exit if loop() was called blocking

[Kishi85]

Description

This is a cleaner variant of #138 that only breaks the QtMainLoop via QApplication::quit when it was started during loop(1) via QApplication::exec. This was missing before causing the QtMainLoop to continue running until the QtTrayMenu object was destroyed eventually and not when tray_exit was called hence the loop(1) call never returning blocking the calling thread.

Screenshot

Issues Fixed or Closed

• Closes fix(qt): clean shutdown by using QueuedConnection and calling QApplication::quit #138

Roadmap Issues

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Unit tests have been added or updated for any new or modified functionality

AI Usage

• None: No AI tools were used in creating this PR
• Light: AI provided minor assistance (formatting, simple suggestions)
• Moderate: AI helped with code generation or debugging specific parts
• Heavy: AI generated most or all of the code changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Kishi85]

This should fix LizardByte/Sunshine#5213 as well by itself.

@solidv could you give this a try and check if my assumption is correct?

[solidv]

This should fix LizardByte/Sunshine#5213 as well by itself.

@solidv could you give this a try and check if my assumption is correct?

yes, it's fixed. thanks for the quick fix!

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.44%. Comparing base (a0381e7) to head (2e1f4bd).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/QtTrayMenu.cpp	40.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   63.69%   63.44%   -0.25%     
==========================================
  Files           5        5              
  Lines         617      621       +4     
  Branches      199      200       +1     
==========================================
+ Hits          393      394       +1     
- Misses        152      154       +2     
- Partials       72       73       +1     

Flag	Coverage Δ
Linux-qt5	52.89% <40.00%> (-0.33%)	⬇️
Linux-qt6	52.89% <40.00%> (-0.33%)	⬇️
Windows	70.67% <ø> (ø)
macOS	56.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/QtTrayMenu.cpp	54.22% <40.00%> (-0.60%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0381e7...2e1f4bd. Read the comment docs.

[github-actions]

Last Updated	2026-05-30 11:19:47 UTC
Source Run	CI Run #627
Commit	2e1f4bd612e1856d6f457364a6911d9c9a0ba688

Screenshot Comparison

PR #139 screenshots vs screenshots baseline.

Matrix: Linux-qt5

Image	Baseline	PR
tray_icon_initial.png
tray_icon_svg.png
tray_icon_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_displayed.png
tray_notification_themed_icon.png

Matrix: Linux-qt6

Image	Baseline	PR
tray_icon_initial.png
tray_icon_svg.png
tray_icon_themed.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_left_click.png
tray_menu_shown.png
tray_notification_displayed.png
tray_notification_themed_icon.png

Matrix: Windows

Image	Baseline	PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png

Matrix: macOS

Image	Baseline	PR
tray_icon_initial.png
tray_menu_checkbox_checked.png
tray_menu_checkbox_unchecked.png
tray_menu_shown.png
tray_notification_displayed.png