CSS/design Improvements#51
Conversation
The span hover rules were under .nav-link already, and <span> is inside .nav-link, so it makes more sense to nest it under .nav-link.
Hover effects are barely seen on mobile anyway, and it makes the mobile nav menu look weird.
Looks a little nicer.
|
@kevinkace please approve and I will merge after approval, thanks! |
|
These are good updates! WRT the fullwidth nav on desktop - is that purely an aesthetic choice? I could make arguments for tighter spacing, but I don't have a strong opinion either way. Let's gather opinions at standup on Weds. |
|
Kevin, or Marley - can one of you be able to screen share on Wed, so those attending can give input? Kevin - please keep the test doc steps updated, and if a branch is ready to test, I can test locally, but will need the dependencies set from start, as I've needed node 22 and other settings for other things, so my env is modified from last times I've checked site locally |
Sorry, completely missed this, it's an aesthetic choice. I had started out just centering it so we can go back to that if that look is preferred. |
|
merging, we can discuss at standup if anyone hass issues. Thanks! |
|
this update is finally live! (a build error that was blocking this was just fixed) |
Hello! I've fixed up a few things with the CSS/design.