Add breakdown for aura effect for aura skills#132
Merged
LocalIdentity merged 1 commit intoFeb 10, 2020
Conversation
Contributor
chinhodado
commented
Jan 19, 2020
chinhodado
commented
Quotae
reviewed
Jan 19, 2020
Contributor
There was a problem hiding this comment.
I'd say remove these extra blank gaps between this if statement and the ones above and below it. They're unnecessary besides looking better when you're editing this file, and fewer lines in the file is better.
Contributor
Author
There was a problem hiding this comment.
I think it makes it easier to read, and 2 blank lines isn't really a big deal when the file is already 2000+ lines long. But if people feel strongly about it I'll remove it, it's not a big deal.
Quotae
reviewed
Jan 19, 2020
chinhodado
force-pushed
the
breakdown_aura
branch
from
5b85ade to
fa4fdac
Compare
ppoelzl
approved these changes
Jan 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.