Fix expanding nodes with more than 32768 children #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a test that reproduced the issue on #52
correctly expands node with 100.000 childrenand the implementation fixed the issue.
Turns out that when chunking the nodes, the two arguments for splice (start and delete) were not taken into account and they add up from chunk to chunk making the subsequent start off by
2*orderPartsCursor(good thing I did the test with 100k nodes and not 40k)One more thing, I ended up adding one extra test
correctly collapses node with 100.000 childrenbut since there was no issue with collapsing I didn't see this one fail. Let me know if you want me to remove it.closes #52