Missing CSV Columnizer #8 #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the problem by reverted change around the default columnizer. Changed the auto search columnizer feature to only search for columnizer when the log file is opened the first time in the LogExpert. Added a test case. Updated csv default separator.
miltob
commented
Aug 11, 2019
|
|
||
| public void InitDefaults() | ||
| { | ||
| delimiterChar = ';'; |
Author
There was a problem hiding this comment.
I am not sure why this was semicolon instead of comma.
Author
There was a problem hiding this comment.
Please let me know if I missed anything.
Collaborator
There was a problem hiding this comment.
Depends on the CSV file. There are some which are delimited by semicolon instead of comma. In my knowledge some people use the semicolon because its not used in "sentences" as for the comma its used often and needs some quotation.
zarunbal
added a commit
that referenced
this pull request
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem by reverted change around the default columnizer.
Changed the auto search columnizer feature to only search for columnizer when the log file is opened the first time in the LogExpert.
Added a test case.
Updated csv default separator.