Skip to content

Conversation

@Hirogen
Copy link
Collaborator

@Hirogen Hirogen commented Nov 28, 2025

This pull request introduces several improvements and fixes to the LogExpert UI, focusing on resource management, UI consistency, and minor code quality enhancements. The most significant changes include the addition of new localized resource strings, improved handling of resource images, UI adjustments for filter controls, and code style improvements for clarity and maintainability.

Resource and Localization Enhancements:

  • Added new localized strings for plugin trust configuration updates and restart recommendations in both Resources.Designer.cs and Resources.resx, enabling user notifications when plugin trust settings change. [1] [2] [3]

UI and Resource Management:

  • Moved assignment of resource images for controls (such as pnlProFilterLabel, btnFilterDown, btnFilterUp, and btnToggleHighlightPanel) from the designer file to a dedicated ApplyResourceImages method in LogWindow.cs, improving maintainability and separation of concerns. [1] [2] [3] [4] [5]
  • Adjusted various UI component sizes and splitter distances to improve layout consistency, particularly for advanced filter panels and list boxes. [1] [2] [3] [4] [5] [6] [7]

Code Quality and Consistency:

  • Replaced deprecated or less precise event handlers (ClosingFormClosing) and improved string handling by replacing "" with string.Empty for clarity. [1] [2] [3]
  • Combined multiple conditional returns into single-line expressions for conciseness and readability, especially in filter-related logic.
  • Updated assignment statements to use discard (_ = ...) where return values are not used, aligning with modern C# conventions. [1] [2] [3]

Minor Refactoring and Static Analysis:

  • Made several methods static where appropriate and improved string comparison by specifying StringComparison.OrdinalIgnoreCase. [1] [2]
  • Renamed a method for clarity (GetIconGetLedIcon). [1] [2]

UI Framework and Theme Adjustments:

  • Set the DocumentStyle property for the dock panel to DockingWindow for improved window management and consistency.
  • Minor font initialization update for theme consistency.

@Hirogen Hirogen merged commit 7fba6b4 into Development Nov 28, 2025
1 check passed
@Hirogen Hirogen deleted the resources_more_housekeeping branch November 28, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants