Skip to content

Refactor LogTabWindow and extract logic that is not needed in the GUI#558

Merged
Hirogen merged 13 commits intoDevelopmentfrom
refactoring
Apr 8, 2026
Merged

Refactor LogTabWindow and extract logic that is not needed in the GUI#558
Hirogen merged 13 commits intoDevelopmentfrom
refactoring

Conversation

@Hirogen
Copy link
Copy Markdown
Collaborator

@Hirogen Hirogen commented Apr 7, 2026

This pull request introduces several improvements and fixes across the codebase, focusing on enhancing test coverage, refining interface documentation, improving null handling, and updating dependencies. The most significant changes are the addition of comprehensive integration and unit tests for LogWindowCoordinator and LogWindow, interface and documentation cleanups, and minor adjustments to test expectations and SDK versions.

New and Improved Test Coverage:

Interface, Documentation, and Usability Improvements:

  • Updated the IContextMenuEntry interface: improved parameter documentation for GetMenuText, removed obsolete method overloads, and clarified remarks about null handling and parameter expectations. [1]], [2]])
  • Cleaned up the ILogWindow interface by removing a redundant summary and ensuring clarity in method documentation. ([src/LogExpert.Core/Interfaces/ILogWindow.csL150-L164])

Bug Fixes and Robustness:

  • Improved null handling in LogfileReader by ensuring that asynchronous methods return Task.FromResult<ILogLineMemory>(null) instead of null, preventing potential runtime issues. [1]], [2]])
  • Added a CopyFrom method to the SearchParams class for safe copying of search parameters between instances, with null checks. ([src/LogExpert.Core/Entities/SearchParams.csR24-R38])

Test Timeout Adjustments:

  • Increased timeout thresholds in ProjectFileValidatorTests to accommodate slower environments and reduce test flakiness. [1]], [2]])

Dependency Updates:

  • Updated the .NET SDK version in global.json from 10.0.100 to 10.0.200. ([global.jsonL3-R3])

Minor Cleanups:

These changes collectively improve reliability, maintainability, and test coverage of the codebase.

Comment on lines +184 to +190
foreach (var entry in _configManager.Settings.ColumnizerHistoryList)
{
if (entry.FileName.Equals(fileName, StringComparison.Ordinal))
{
return entry;
}
}
@Hirogen Hirogen merged commit a867284 into Development Apr 8, 2026
1 check passed
@Hirogen Hirogen deleted the refactoring branch April 8, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant