BQ storage write api - Mint pool#3272
Merged
Ziinc merged 11 commits intoLogflare:mainfrom Apr 15, 2026
Merged
Conversation
bblaszkow06
force-pushed
the
bb/bigquery-streaming-insert-perf
branch
4 times, most recently
from
ff9c25f to
6a3f159
Compare
Ziinc
changed the title
Upgrades grpc ~> 0.11.0 and adds a persistent, supervised round-robin channel pool using the built-in Mint adapter to replace the per-call GRPC.Stub.connect (backed by the custom Finch adapter). - Add GrpcPool supervisor with per-index GrpcChannelMonitor GenServers; channels are registered in a per-pool Registry and selected via an atomic counter for lock-free round-robin dispatch - Add GrpcAuthInterceptor: fetches a fresh Goth token per call and injects it as gRPC metadata, replacing the per-call auth header on the channel - Remove local Google.Rpc.* protobuf definitions now provided by the googleapis transitive dep (pulled in by grpc 0.11.x) - Add GRPC.Client.Supervisor to Networking.pools/0 (required by grpc 0.11.x for outbound connections) - google_api_client: use GrpcPool.get_channel/1 and remove Goth.fetch; auth is now handled transparently by the interceptor
bblaszkow06
force-pushed
the
bb/bigquery-streaming-insert-perf
branch
2 times, most recently
from
00d0357 to
1d15a33
Compare
Ziinc
requested changes
Apr 15, 2026
| setup do | ||
| insert(:plan) | ||
| start_supervised!(AllLogsLogged) | ||
| start_supervised!(GRPC.Client.Supervisor) |
Contributor
There was a problem hiding this comment.
Seems like unnecessary change as there is no client interaction in this test
Contributor
Author
There was a problem hiding this comment.
Actually, there is - in line 35, there's Client.connect that sends a request via localhost.
The change was needed due to :grpc version bump. The supervisor used to be started with :grpc app, but in the current version, it has to be started manually and isn't started in tests
| setup do | ||
| insert(:plan) | ||
| start_supervised!(AllLogsLogged) | ||
| start_supervised!(GRPC.Client.Supervisor) |
| insert(:plan) | ||
| start_supervised!(AllLogsLogged) | ||
| start_supervised!(GRPC.Client.Supervisor) | ||
|
|
| health: logflare_health, | ||
| http_connection_pools: http_connection_pools | ||
| http_connection_pools: http_connection_pools, | ||
| bq_write_api_pool_size: System.get_env("LOGFLARE_BQ_WRITE_API_POOL_SIZE") |
Contributor
There was a problem hiding this comment.
Suggested change
| bq_write_api_pool_size: System.get_env("LOGFLARE_BQ_WRITE_API_POOL_SIZE") | |
| bq_write_api_pool_size: System.get_env("LOGFLARE_BIGQUERY_WRITE_API_POOL_SIZE") |
In my opinion we should automatically manage connection pool. But we can give this a try first. Needs a sensible default too.
Ziinc
approved these changes
Apr 15, 2026
Contributor
Ziinc
left a comment
Ziinc
left a comment
There was a problem hiding this comment.
Will merge in first for testing. Please address comments in follow up PRs 🙏
| {Logflare.Networking.GrpcPool, | ||
| name: GoogleApiClient.connetion_pool_name(), | ||
| url: "https://bigquerystorage.googleapis.com", | ||
| size: Application.get_env(:logflare, :bq_write_api_pool_size, 25)} |
Contributor
There was a problem hiding this comment.
Default should be set at runtime.exs instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of the Mint-adapter-based Storage Write API.
Retries and error handling will be covered by following PRs to keep this manageable.
Closes O11Y-1513